Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(Code Issue): Code Issue in /plugins/notifications/sendgrid #7068

Open
1 of 2 tasks
riivostolts opened this issue Apr 14, 2024 · 1 comment
Open
1 of 2 tasks

Docs(Code Issue): Code Issue in /plugins/notifications/sendgrid #7068

riivostolts opened this issue Apr 14, 2024 · 1 comment

Comments

@riivostolts
Copy link

Preliminary Checks

Issue Summary

There is a wrong key shown in the docs for "Order Shipment Created" template. order_shipped_template does not pass the condition in sendgrid.js's getTemplateId function.

How can this issue be resolved?

  1. order_shipped_template should be renamed to order_shipment_created_template

Are you interested in working on this issue?

  • I would like to fix this issue
tesfamickal added a commit to tesfamickal/medusa that referenced this issue Apr 22, 2024
@shahednasser
Copy link
Member

Nice catch! Seems like it's a bug in the sendgrid plugin, where if the template is passed in the plugin's options without a locale, it looks for order_shipment_created_template, whereas in the localized options, it looks for order_shipped_template.

Will report it and add a temporary note in the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants