Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] order_shipped_template does not pass the condition in sendgrid js getTemplateId function. #7159

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ByronKweh
Copy link

Solves this issue and potential allows us to close this PR

First time PR here, please be gentle if I misstepped!

Copy link

changeset-bot bot commented Apr 26, 2024

⚠️ No Changeset found

Latest commit: 93c0ce2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 26, 2024

@ByronKweh is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@luluhoc
Copy link
Contributor

luluhoc commented Apr 29, 2024

I rewrote the plugin to typescript with this issue fixed no response whatsoever #5984

@ByronKweh ByronKweh closed this Apr 30, 2024
@ByronKweh ByronKweh reopened this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants