fix: correct calculations of subtotal for shipping option requirements #7089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinfurmanski
requested review from
sradevski,
carlos-r-l-rodrigues and
olivermrbl
🦋 Changeset detectedLatest commit: c12f410 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@kevinfurmanski is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
sradevski
approved these changes
Apr 17, 2024
kevinfurmanski
force-pushed
the
fix/shipping-option-requirement-basis
branch
from
c7fd37e
to
c12f410
Compare
|
@sradevski I added a changeset and rebased from develop |
|
@olivermrbl Just a heads up, maybe we should also include this in today's release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using min/max subtotal for shipping options, there is a case when the
listCartOptionsmethod in medusa-js will return the wrong option. If I have a "Paid shipping" option between 0-999 SEK costing 29 SEK and a "Free shipping" option of orders above 999 SEK and the line items amount to for example 980 SEK, then when you select the "Paid shipping" option for 29 SEK the order total goes over 999 SEK and the "Paid shipping" option is hidden and instead the "Free shipping" option is shown. When you then press the "Free shipping" option the order total goes under 999 SEK and the "Free shipping" option is hidden and the "Paid shipping" option is shown again. It's an endless cycle that you can't get out of due to the fact that the shipping cost is included in the total. This should be modified to not include the shipping price.