Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "precommands" to benchmark #4624

Merged
merged 3 commits into from May 13, 2024
Merged

Add "precommands" to benchmark #4624

merged 3 commits into from May 13, 2024

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented May 7, 2024

Pull Request

Related issue

Helps for #4493

What does this PR do?

  • Add support for precommands for cargo xtask bench
  • update benchmark docs
  • update workload files

@dureuill dureuill added this to the v1.9.0 milestone May 7, 2024
@dureuill
Copy link
Contributor Author

dureuill commented May 7, 2024

/bench workloads/*.json

irevoire
irevoire approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

@dureuill
Copy link
Contributor Author

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented May 13, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 76bb6d5 into main May 13, 2024
10 checks passed
@meili-bors meili-bors bot deleted the precommands branch May 13, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

@Kerollmops Kerollmops Awaiting requested review from Kerollmops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dureuill @irevoire