Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show spinner animation when adding plugins #8234

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

raiatul14
Copy link
Contributor

@raiatul14 raiatul14 commented Oct 20, 2023

Closes #7803
added yaspin spinner animation for 'add plugin' service

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for meltano canceled.

Name Link
🔨 Latest commit 310f5ce
🔍 Latest deploy log https://app.netlify.com/sites/meltano/deploys/65b8120f7fbdc40008bedb51

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdf8649) 91.50% compared to head (310f5ce) 91.49%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8234      +/-   ##
==========================================
- Coverage   91.50%   91.49%   -0.02%     
==========================================
  Files         244      244              
  Lines       19125    19127       +2     
  Branches     2140     2141       +1     
==========================================
- Hits        17501    17500       -1     
- Misses       1343     1346       +3     
  Partials      281      281              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillDaSilva WillDaSilva changed the title feat: (Issue #7803) added yaspin spinner animation for 'add plugin' s… feat: Show spinner animation when adding plugins Oct 20, 2023
@edgarrmondragon
Copy link
Collaborator

@raiatul14 Would you still be interested in getting this across?

@raiatul14
Copy link
Contributor Author

@raiatul14 Would you still be interested in getting this across?

@edgarrmondragon sure. If you feel something is missing then please let me know. Thanks!

@edgarrmondragon
Copy link
Collaborator

@raiatul14 Would you still be interested in getting this across?

@edgarrmondragon sure. If you feel something is missing then please let me know. Thanks!

I think the current implementation is missing what's probably the most important long-running command, i.e. meltano install. Do you think it's worth wrapping meltano.cli.utils:install_plugins with the yaspin context so it's applicable in other places?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Long running commands should include a spinner animation
3 participants