feat: Added a include_callsite_parameters argument to the builtin log formatters, which adds source path, line number and function name fields to the emitted log
#8494
+70
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meltano ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/logging-callsite-parameters
branch
from
d6f6e8c
to
544f26b
Compare
…og formatters, which adds source path, line number and function name fields to the emitted log
Example usage:
```yaml
formatters:
json: # log format for json formatted logs
(): meltano.core.logging.json_formatter
include_callsite_parameters: true
```
It can also be passed to the
`meltano.core.logging.console_log_formatter` and `meltano.core.logging.key_value_formatter` formatters.
https://www.structlog.org/en/stable/api.html#structlog.processors.CallsiteParameterAdder
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/logging-callsite-parameters
branch
from
544f26b
to
67b4224
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8494 +/- ##
=======================================
Coverage 91.78% 91.79%
=======================================
Files 245 245
Lines 19325 19336 +11
Branches 2149 2150 +1
=======================================
+ Hits 17738 17750 +12
+ Misses 1313 1312 -1
Partials 274 274 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/logging-callsite-parameters
branch
from
e0128d1
to
3454226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example usage:
It can also be passed to the
meltano.core.logging.console_log_formatterandmeltano.core.logging.key_value_formatterformatters.https://www.structlog.org/en/stable/api.html#structlog.processors.CallsiteParameterAdder