Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix “Failed to remove the module $MODULE” warnings #213

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antepusic
Copy link
Collaborator

Description

Upon the removal of query modules (e.g. when shutting down Memgraph), warnings such as these are consistently logged:

[2023-04-05 16:35:36.374] [Warning] Failed to remove the module mgp_networkx from sys.modules
[2023-04-05 16:35:36.378] [Warning] Failed to remove the module mgp_igraph from sys.modules
[2023-04-05 16:35:36.428] [Warning] Failed to remove the module igraphalg from sys.modules

This PR fixes the issue by relocating two helper modules (mgp_networkx and mgp_igraph) from /python to /python/mage.

Pull request type

  • Bugfix

Related issues

#212

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Unit tests
  • End-to-end tests
  • Code documentation
  • README short description
  • Documentation on memgraph/docs

######################################

@antepusic antepusic added type: bug Something isn't working lang: python Issue on Python codebase status: ready PR is ready for review labels Apr 17, 2023
@antepusic antepusic self-assigned this Apr 17, 2023
@antepusic antepusic marked this pull request as draft April 18, 2023 06:50
@antepusic antepusic added In progress and removed status: ready PR is ready for review labels Apr 18, 2023
@antoniofilipovic
Copy link
Collaborator

@antepusic can we close this?

@antepusic
Copy link
Collaborator Author

@antoniofilipovic I think we’re fine closing this – it was a harmless issue even when the PR was opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In progress lang: python Issue on Python codebase type: bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants