Add latest cuGraph #458

gitbuda · 2024-03-29T16:52:22Z

Docker Build Commands

docker build -f Dockerfile.experiment_partial -t mage-cugraph-part --progress plain .
docker run -it --rm --gpus all mage-cugraph-part bash

docker build -f Dockerfile.experiment_full -t mage-cugraph-full --progress plain .

docker run -it --rm --gpus all mage-cugraph-full bash
cd /mage/cpp/build
cmake -DMAGE_CUGRAPH_ENABLE=ON -DMAGE_CUGRAPH_ROOT=/opt/conda ..
VERBOSE=1 make cugraph.pagerank
make cugraph.pagerank cugraph.personalized_pagerank cugraph.louvain cugraph.katz_centrality cugraph.leiden cugraph.betweenness_centrality cugraph.balanced_cut_clustering cugraph.spectral_clustering cugraph.hits cugraph.generator

python3 /mage/setup build --gpu --cpp-build-flags CMAKE_BUILD_TYPE=Release MAGE_CUGRAPH_ROOT=/opt/conda/ -p /usr/lib/memgraph/query_modules/

docker run -it --rm --gpus all -p 7687:7687 mage-cugraph-full --log-level=TRACE --also-log-to-stderr

# if building memgraph, do it outside the /mage/cpp/memgraph because that's copied to during Docker build
cd /tmp/mage/cpp/dist
cp ../build/cugraph_module/cugraph.pagerank.so ./

cd /tmp/mage && ./test_e2e -k "pagerank_test-test_cugraph_influential"

Docker Base Images

Done

Compile only the cuGraph module with latest everything
- python3 /mage/setup build --gpu --cpp-build-flags MAGE_CUGRAPH_ROOT=/opt/conda CMAKE_C_COMPILER=gcc CMAKE_CXX_COMPILER=g++ -p /usr/lib/memgraph/query_modules
- Figure out what's wrong with fmt (when all is compiled), again issues with fmt+spdlog, spdlog from /opt/conda is not ok (maybe interesting Unable to compile spdlog with GCC gabime/spdlog#2825); fmt v9 doesn't compile with used g++, fmt v10 doesn't work with the spdlog in the /opt/conda
  - Potential solution -> Using external fmt results in missing header spdlog/fmt/bundled/core.h gabime/spdlog#1897
- cugraph/algorithms.hpp for some reason doesn't work -> make sure GPU+Docker is ok
- Figure out the problem with cuda code under conda -> most likely some build config issue 🤔 -> Switch to cuda::stream_ref NVIDIA/cuCollections#331 (comment)
- API fixes
Find and link libcugraph-ops++.so and libraft.so -> taken from rapidsai/base Docker image under /opt/conda/lib
Make cugraph.pagerank to work correctly, implement the package process and release Docker image only with memgraph and pagerank internally

Experiment / Optional

Take a look at the edge mask feature (there is no masking of vertices)

Description

Please briefly explain the changes you made here.

Pull request type

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

Documentation checklist

Add the documentation label tag
Add the bug / feature label tag
Add the milestone for which this feature is intended
- If not known, set for a later milestone
Write a release note, including added/changed clauses
- [Release note text]
Link the documentation PR here
- [Documentation PR link]
Tag someone from docs team in the comments

gitbuda · 2024-05-16T15:10:00Z

cpp/cugraph_cmake/cugraph.cmake

@@ -108,6 +110,6 @@ macro(target_mage_cugraph target_name)
      PRIVATE "$<$<COMPILE_LANGUAGE:CXX>:${MAGE_CXX_FLAGS}>"
              "$<$<COMPILE_LANGUAGE:CUDA>:${MAGE_CUDA_FLAGS}>"
    )
-    target_link_libraries("${target_name}" PRIVATE mage_cugraph)
+    target_link_libraries("${target_name}" PRIVATE mage_cugraph CUDA::toolkit)


The CUDA::toolkit here probably should be deleted here because it's already included.

gitbuda · 2024-05-16T15:13:07Z

cpp/cugraph_module/algorithms/betweenness_centrality.cu

@@ -64,8 +64,8 @@ void BetweennessProc(mgp_list *args, mgp_graph *graph, mgp_result *result, mgp_m
        weight_property, kDefaultWeight);
    if (mg_graph->Empty()) return;

+    // TODO(gitbuda): The betweenness_centrality legacy function still works -> try to replace with latest option.


Use this https://github.com/rapidsai/cugraph/blob/37b67c95a4e0f4546ee7297bb546b6aed14b01a1/cpp/include/cugraph/algorithms.hpp#L342 implementation

gitbuda · 2024-05-16T15:15:51Z

cpp/cugraph_module/mg_cugraph_utility.hpp

+  // TODO(gitbuda): Update types and inject valid ids / edge types.
+  rmm::device_uvector<int64_t> cu_edge_ids(mg_edge_ids.size(), stream);
+  raft::update_device(cu_edge_ids.data(), mg_edge_ids.data(), mg_edge_ids.size(), stream);
+  rmm::device_uvector<int32_t> cu_edge_types(mg_edge_types.size(), stream);
+  raft::update_device(cu_edge_types.data(), mg_edge_types.data(), mg_edge_types.size(), stream);


This is all optional, the only algo using edge edge ids and types, uniform_neighbor sampling, part of the GNN workflow

gitbuda · 2024-05-16T15:19:05Z

cpp/cugraph_module/mg_cugraph_utility.hpp

          handle, std::move(cu_vertices), std::move(cu_src), std::move(cu_dst), std::move(cu_weight),
-          cugraph::graph_properties_t{false, false}, false, false);
+          std::move(cu_edge_ids), std::move(cu_edge_types), cugraph::graph_properties_t{false, false}, false, false);
  stream.synchronize_no_throw();

  return std::move(cu_graph);


Add weights here that's 100% required

gitbuda · 2024-05-16T15:22:05Z

cpp/cugraph_module/mg_cugraph_utility.hpp

+  // TODO(gitbuda): Update types and inject valid ids / edge types.
+  rmm::device_uvector<int64_t> cu_edge_ids(mg_edge_ids.size(), stream);
+  raft::update_device(cu_edge_ids.data(), mg_edge_ids.data(), mg_edge_ids.size(), stream);
+  rmm::device_uvector<int32_t> cu_edge_types(mg_edge_types.size(), stream);


edge type is int32_t if prebuilt libraries are use
but since this is not used in our current use-cases, delete this part because it will just do useless work

gitbuda · 2024-05-16T15:26:02Z

cpp/cugraph_module/algorithms/leiden.cu

    // Define handle and operation stream
    raft::handle_t handle{};
    auto stream = handle.get_stream();
+    // TODO(gitbuda): Inject the valid seed.
+    raft::random::RngState rng_state(0);


some mechanism for selecting random seed
depends on the use-case, param to the caller, there is a parallel race condition 10% of the times with the same seed

nad010286 · 2024-05-30T16:49:07Z

any update? look like cugraph.pagerank still results different output compared with pagerank cpu version

gitbuda · 2024-05-30T16:52:10Z

@nad010286 nothing yet, just didn't have a chance to finish this work, but it's still on the short-term TODO list 😄

gitbuda · 2024-06-02T17:41:26Z

Hi @nad010286! I've made some progress on a small scale. Seems like the regular CPU pagerank and cugraph pagerank are producing the same outputs (CPU test case vs cugraph test case) 🤔

Can you please provide a test case from your side (something reasonable in size, max 100k nodes + edges), in the e2e test format 🙏:

The graph should be in the .cyp format (it's actually cypher per line, it can be many lines, but it's important to not break down single query into multiple lines) GRAPH INPUT EXAMPLE
The test case should be in the .yml format (make sure you have everything, the exact query, and exact outputs) TEST CASE EXAMPLE

sonarcloud · 2024-06-02T18:14:30Z

Quality Gate failed

Failed conditions
6 Security Hotspots

See analysis details on SonarCloud

nad010286 · 2024-06-06T08:13:43Z

Hi @nad010286! I've made some progress on a small scale. Seems like the regular CPU pagerank and cugraph pagerank are producing the same outputs (CPU test case vs cugraph test case) 🤔

Can you please provide a test case from your side (something reasonable in size, max 100k nodes + edges), in the e2e test format 🙏:

The graph should be in the .cyp format (it's actually cypher per line, it can be many lines, but it's important to not break down single query into multiple lines) GRAPH INPUT EXAMPLE

The test case should be in the .yml format (make sure you have everything, the exact query, and exact outputs) TEST CASE EXAMPLE

hey, Im having issue to build the cuGraph and MAGE from source :( any instructions or things I have to pay attention to? Or if you can send me the docker image that you already built, Im happy to perform some tests for you with loads of graph data

gitbuda and others added 17 commits March 29, 2024 16:51

Add latest cuGraph

f1674d1

Update all versions

5859b13

Fix libcugraph paths

8dd7aec

Make pip install to pass, dgl fails because of FindCUDA arch unknown

d7b5880

Add experiments_to_delete script

dee55aa

Add Dockerfile.experiment

af269d3

spdlog making problems

c7f3828

Move to Memgraph v2.16.0

4cae1fe

Add potential solution for spdlog

93a3be9

Fix basic includes and arch setup

38dcb33

Add latest changes, mostly comments and all on rapids v24.04

f9b297b

Align everything to C++17 but it does NOT help

43295ab

Fix basic compilation errors -> cugraph API changed -> FIXIT

b9db63a

Move to the latest memgraph

26ddd45

All cugraph modules are compilable -> TESTING next

f9eaf83

Add working cugraph.pagerank

a233c5a

Build and package all, tests still fails (deps)

7a121ba

gitbuda commented May 16, 2024

View reviewed changes

gitbuda added 2 commits June 2, 2024 17:01

Add IPR example1 for CPU and GPU

e7af2d9

Improve and suppress some warnings under pagerank

061c0c9

Add list command to test_e2e

8959cf9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add latest cuGraph #458

Add latest cuGraph #458

gitbuda commented Mar 29, 2024 •

edited

gitbuda May 16, 2024

gitbuda May 16, 2024

gitbuda May 16, 2024 •

edited

gitbuda May 16, 2024

gitbuda May 16, 2024

gitbuda May 16, 2024

nad010286 commented May 30, 2024

gitbuda commented May 30, 2024

gitbuda commented Jun 2, 2024 •

edited

sonarcloud bot commented Jun 2, 2024

nad010286 commented Jun 6, 2024 •

edited

Add latest cuGraph #458

Are you sure you want to change the base?

Add latest cuGraph #458

Conversation

gitbuda commented Mar 29, 2024 • edited

Docker Build Commands

Docker Base Images

Done

Experiment / Optional

Description

Pull request type

Related issues

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

Documentation checklist

gitbuda May 16, 2024

Choose a reason for hiding this comment

gitbuda May 16, 2024

Choose a reason for hiding this comment

gitbuda May 16, 2024 • edited

Choose a reason for hiding this comment

gitbuda May 16, 2024

Choose a reason for hiding this comment

gitbuda May 16, 2024

Choose a reason for hiding this comment

gitbuda May 16, 2024

Choose a reason for hiding this comment

nad010286 commented May 30, 2024

gitbuda commented May 30, 2024

gitbuda commented Jun 2, 2024 • edited

sonarcloud bot commented Jun 2, 2024

Quality Gate failed

nad010286 commented Jun 6, 2024 • edited

gitbuda commented Mar 29, 2024 •

edited

gitbuda May 16, 2024 •

edited

gitbuda commented Jun 2, 2024 •

edited

nad010286 commented Jun 6, 2024 •

edited