Fixed download of california housing dataset #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source .tar file containing two files in the directory. The solution implemented is similar to how sklearn implements fetching the cal-housing dataset. I added a cache in the users home directory to avoid multiple downloads. Theoretically you could also just use a temp directory, but that would mean that the dataset is downloaded multiple times, which is very annyoing for testing and debugging. Link to sklearn implementation: https://github.com/scikit-learn/scikit-learn/blob/364c77e04/sklearn/datasets/_california_housing.py\#L53
…source .tar file containing two files in the directory. The solution implemented is similar to how sklearn implements fetching the cal-housing dataset. I added a cache in the users home directory to avoid multiple downloads. Theoretically you could also just use a temp directory, but that would mean that the dataset is downloaded multiple times, which is very annyoing for testing and debugging. Link to sklearn implementation: https://github.com/scikit-learn/scikit-learn/blob/364c77e04/sklearn/datasets/_california_housing.py\#L53
…source .tar file containing two files in the directory. The solution implemented is similar to how sklearn implements fetching the cal-housing dataset. I added a cache in the users home directory to avoid multiple downloads. Theoretically you could also just use a temp directory, but that would mean that the dataset is downloaded multiple times, which is very annyoing for testing and debugging. Link to sklearn implementation: https://github.com/scikit-learn/scikit-learn/blob/364c77e04/sklearn/datasets/_california_housing.py\#L53
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug in the California housing dataset that was caused by the source .tar file containing two files in the directory. The solution implemented is similar to how sklearn implements fetching the cal-housing dataset. I added a cache in the users home directory to avoid multiple downloads. Theoretically you could also just use a temp directory, but that would mean that the dataset is downloaded multiple times, which is very annoying for testing and debugging.
Link to sklearn implementation:
https://github.com/scikit-learn/scikit-learn/blob/364c77e04/sklearn/datasets/_california_housing.py\#L53