Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLC-LLM] Introducing Llama 3 running locally on Android using MLC-LLM #506

Merged
merged 16 commits into from
May 16, 2024

Conversation

tmoreau89
Copy link
Contributor

What does this PR do?

This PR introduces a guide on how to run Llama 3 8B instruct on an Android Phone using MLC LLM!

Feature/Issue validation/testing

This tutorial was tested with the following setup:

  • MacBook Pro 16 inch from 2021 with Apple M1 Max and 32GB of RAM running Sonoma 14.3.1
  • OnePlus 12 Android Smartphone with a Snapdragon 8Gen3 SoC and 12GB or RAM, running OxygenOS 14.0

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

@tmoreau89
Copy link
Contributor Author

CC @HamidShojanazeri - the long awaited MLC-LLM tutorial!

@tmoreau89
Copy link
Contributor Author

@HamidShojanazeri we're green on spellcheck here, but the linter has issues with the following two URLs:

The error saying Status: 0 Error: Exceeded maxRedirects. Probably stuck in a redirect loop.

Unclear why but is there a way to get the linter to ignore these URLs?

@HamidShojanazeri
Copy link
Contributor

sorry @tmoreau89 its the linter bug, can you pls add <!-- markdown-link-check-disable --> ,<!-- markdown-link-check-enable --> surrounding the link, https://github.com/meta-llama/llama-recipes/pull/291/files

@tmoreau89
Copy link
Contributor Author

@HamidShojanazeri I think we're good to go on this one! Thanks for the tip!

@HamidShojanazeri
Copy link
Contributor

HamidShojanazeri commented May 15, 2024

@tmoreau89 seems its still failing on "./mlc-package-config.json → Status: 400 [Error: ENOENT: no such file or directory, access '/github/workspace/recipes/inference/mobile_inference/android_inference/mlc-package-config.json']", would appreciate the fix to make the CI green thanks!

@tmoreau89
Copy link
Contributor Author

@HamidShojanazeri Morning! The checks are all green now (this time for real 😆 )

Copy link
Contributor

@HamidShojanazeri HamidShojanazeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tmoreau89 for the PR!

@HamidShojanazeri HamidShojanazeri merged commit 519c5a6 into meta-llama:main May 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants