Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for M1/M2 Apple Silicon #87

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pianistprogrammer
Copy link

No description provided.

@facebook-github-bot
Copy link

Hi @pianistprogrammer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@pianistprogrammer
Copy link
Author

I have now registered for the write access to add pull request and signed the Individual Contributor License Agreement

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 20, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@multics
Copy link

multics commented Apr 21, 2024

tested on my MacBook Pro M2, and got following error:

RuntimeError: Placeholder storage has not been allocated on MPS device!

@pianistprogrammer Have you tested the PR?

@pygaurav
Copy link

Same issue for me -> RuntimeError: Placeholder storage has not been allocated on MPS device!

@vishnui
Copy link

vishnui commented May 1, 2024

Same issue for me: RuntimeError: Placeholder storage has not been allocated on MPS device!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants