metabase.analyze API namespace

[camsaul]

No description provided.

[camsaul]

I renamed this because classifiers.name/infer-entity-type clearly implied this was based on column name, however analyze/infer-entity-type lost that clarity

[crisptrutski]

This seems to introduce a circular reference:

Cyclic load dependency: 

** /metabase/query_processor/compile **

-> /metabase/query_processor
-> /metabase/db/metadata_queries
-> /metabase/models/field_values
-> /metabase/analyze/classifiers/category
-> /metabase/analyze/classifiers/core
-> /metabase/analyze
-> /metabase/query_processor/middleware/annotate
-> /metabase/query_processor/preprocess

** /metabase/query_processor/compile **

-> /metabase/driver/common/parameters/values
-> /metabase/driver/sql
-> /metabase/driver/oracle

[crisptrutski]

This exposes a thorny circular dependency between the query-processor and analyze modules, not sure the easiest way to resolve that.

Otherwise this looks hunky dory

[replay-io]

Status	Complete ↗︎
Commit	37024a2
Results	⚠️ 1 Flaky ✅ 2572 Passed

[crisptrutski]

Nicely done

[crisptrutski]

This dependency bothers me a bit, in my mind models shouldn't depend on higher level modules, if possible. We could "fix" this by moving the constants out to a general config namespace at some point.

[camsaul]

agreed, but that's a step 2 thing and step 1 is just getting things in modules. It's going to take a while and several iterations to clean everything up