Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBQL lib] Add native queries to the shared tests for all drills #42478

Merged
merged 1 commit into from May 14, 2024

Conversation

bshepherdson
Copy link
Contributor

Follow up to #42424.

This enforces that all drills do not appear on native stages.
Also fixes one more drill on top of the two in #42424 that were wrongly
showing up for native queries.

@bshepherdson bshepherdson requested a review from camsaul as a code owner May 9, 2024 19:24
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bshepherdson and the rest of your teammates on Graphite Graphite

@metabase-bot metabase-bot bot added the .Team/QueryProcessor :hammer_and_wrench: label May 9, 2024
@bshepherdson bshepherdson requested a review from metamben May 9, 2024 19:25
@bshepherdson bshepherdson added the no-backport Do not backport this PR to any branch label May 9, 2024
Copy link

replay-io bot commented May 9, 2024

Status In Progress ↗︎ 51 / 52
Commit c44ca0e
Results
⚠️ 2 Flaky
2505 Passed

test/metabase/lib/drill_thru/test_util/canned.cljc Outdated Show resolved Hide resolved
test/metabase/lib/drill_thru/test_util/canned.cljc Outdated Show resolved Hide resolved
Follow up to #42424.

This enforces that all drills do not appear on native stages.
Also fixes one more drill on top of the two in #42424 that were wrongly
showing up for native queries.
@bshepherdson bshepherdson enabled auto-merge (squash) May 14, 2024 19:35
@bshepherdson bshepherdson merged commit a6039a0 into master May 14, 2024
111 checks passed
@bshepherdson bshepherdson deleted the mblib-drills-test-native branch May 14, 2024 20:20
Copy link

@bshepherdson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants