Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics] Remove support for joining on metrics #42513

Merged
merged 2 commits into from May 13, 2024

Conversation

bshepherdson
Copy link
Contributor

[Metrics] Remove support for joining on metrics

Effectively a revert of #42222 and #42300.

Fixes #42471.

@metabase-bot metabase-bot bot added the .Team/QueryProcessor :hammer_and_wrench: label May 10, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bshepherdson and the rest of your teammates on Graphite Graphite

@bshepherdson bshepherdson added the no-backport Do not backport this PR to any branch label May 10, 2024
Copy link

replay-io bot commented May 10, 2024

Status Complete ↗︎
Commit 454fc25
Results
⚠️ 6 Flaky
2478 Passed

Copy link
Contributor

@metamben metamben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to actively prevent joining anything when the source is a metric?

Ideally @snoe should also have a look and check he needs anything from the code removed here.

@bshepherdson bshepherdson merged commit d83fa07 into metrics-v2 May 13, 2024
143 of 153 checks passed
@bshepherdson bshepherdson deleted the mblib-metrics-disable-joins branch May 13, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants