Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove google analytics #42515

Merged
merged 1 commit into from May 13, 2024
Merged

remove google analytics #42515

merged 1 commit into from May 13, 2024

Conversation

npretto
Copy link
Member

@npretto npretto commented May 10, 2024

Description

We haven't been using it for a while, and it was blocked by CSP anyway:

analytics.js:24 Refused to load the script 'https://www.googletagmanager.com/gtag/js?id=xxxxx&cx=c&_slc=1' because it violates the following Content Security Policy directive: "script-src 'self' https://maps.google.com https://accounts.google.com https://www.google-analytics.com 'sha256-9uFLu5CG8mWlvx0LK6lgendCxUX57TuWk3wkgZpBeWU=' 'sha256-ib2/2v5zC6gGM6Ety7iYgBUvpy/caRX9xV/pzzV7hf0=' 'sha256-isH538cVBUY8IMlGYGbWtBwr+cGqkc4mN6nLcA7lUjE='". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback.

@npretto npretto requested a review from camsaul as a code owner May 10, 2024 15:34
@npretto npretto requested a review from a team May 10, 2024 15:34
@npretto npretto added the no-backport Do not backport this PR to any branch label May 10, 2024
@replay-io replay.io
Copy link

replay-io bot commented May 10, 2024 •
edited

Status Complete ↗︎
Commit 4acc180
Results
⚠️ 7 Flaky
✅ 2477 Passed

@npretto npretto merged commit 84519c8 into master May 13, 2024
131 of 148 checks passed
@npretto npretto deleted the nuke-google-analytics branch May 13, 2024 07:44
@github-actions GitHub Actions
Copy link

@npretto Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@nemanjaglumac nemanjaglumac mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranquild ranquild ranquild approved these changes

@uladzimirdev uladzimirdev uladzimirdev approved these changes

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

Assignees

@npretto npretto

Labels
no-backport Do not backport this PR to any branch .Team/Embedding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@npretto @ranquild @uladzimirdev