Drop unsupported locales from moment #42521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff eca348e...3704ca9.
|
uladzimirdev
force-pushed
the
shake-moment
branch
from
0044cb0
to
3704ca9
Compare
uladzimirdev
changed the title
alxnddr
approved these changes
May 15, 2024
alxnddr
reviewed
May 16, 2024
| // https://www.metabase.com/docs/latest/configuring-metabase/localization | ||
| new MomentLocalesPlugin({ | ||
| localesToKeep: [ | ||
| "sq", |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42552
Description
moment includes all locales by default, increasing bundle size, but we don't need some of them
How to verify
verify the list of supported locales and try to change locale in admin settings
Demo
Before
After