Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics E2E tests part 2 #42530

Merged
merged 28 commits into from May 13, 2024
Merged

Conversation

ranquild
Copy link
Contributor

metrics-editing.cy.spec.ts from #42278

verifyLineAreaBarChart({ xAxis: "Product → Category", yAxis: "Count" });
});

it("should pin new metrics automatically", () => {
Copy link
Contributor Author

@ranquild ranquild May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collection-based tests would go to a separate file, but I wanted to make sure that the entire flow works, e.g. when you create a metric via UI and not via API

@ranquild ranquild requested a review from a team May 10, 2024 18:31
@ranquild ranquild added the no-backport Do not backport this PR to any branch label May 10, 2024
Copy link

replay-io bot commented May 10, 2024

Status Complete ↗︎
Commit e9f37ae
Results
⚠️ 6 Flaky
2497 Passed

@ranquild ranquild enabled auto-merge (squash) May 13, 2024 20:53
@ranquild ranquild merged commit 22d4ae4 into metrics-v2 May 13, 2024
111 checks passed
@ranquild ranquild deleted the 42278-metrics-v2-missing-e2e-tests branch May 13, 2024 21:24
@ranquild ranquild changed the title Add missing e2e tests for editing metrics Metrics E2E tests part 2 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants