Add a type to collections returned by search #42535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
johnswanson
force-pushed
the
localize-trash-name
branch
from
b324e1b
to
ff2f1ea
Compare
Base automatically changed from
localize-trash-name
to
make-trash-usable-feature-branch
May 13, 2024 20:33
johnswanson
force-pushed
the
add-type-to-collections-returned-by-search
branch
from
7559ae2
to
c3a8ce4
Compare
johnswanson
force-pushed
the
make-trash-usable-feature-branch
branch
from
0b15fa0
to
f08a457
Compare
johnswanson
force-pushed
the
add-type-to-collections-returned-by-search
branch
3 times, most recently
from
c9864f5
to
00ffab4
Compare
sloansparger
force-pushed
the
make-trash-usable-feature-branch
branch
from
85065a8
to
c2a1917
Compare
Under: - `item.type` - `item.collection.type`, and - `item.collection.effective_ancestors.*.type`
johnswanson
force-pushed
the
add-type-to-collections-returned-by-search
branch
from
00ffab4
to
507cf7a
Compare
noahmoss
approved these changes
May 17, 2024
|
@johnswanson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
oisincoveney
pushed a commit
that referenced
this pull request
May 20, 2024
Under: - `item.type` - `item.collection.type`, and - `item.collection.effective_ancestors.*.type`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under:
item.typeitem.collection.type, anditem.collection.effective_ancestors.*.type