Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude jspdf and html2canvas from the bundle #42536

Merged
merged 2 commits into from May 18, 2024
Merged

Exclude jspdf and html2canvas from the bundle #42536

merged 2 commits into from May 18, 2024

Conversation

uladzimirdev
Copy link
Contributor

@uladzimirdev uladzimirdev commented May 10, 2024 •
edited

Closes #42551

Description

Create separate chunks for jspdf and html2canvas

How to verify

Make sure export dashboard to pdf works as before

Demo

Before

Screenshot 2024-05-13 at 10 12 06

After
Screenshot 2024-05-13 at 10 30 38
Screenshot 2024-05-13 at 10 30 45

@replay-io replay.io
Copy link

replay-io bot commented May 11, 2024 •
edited

Status Complete ↗︎
Commit 5f41c0f
Results
⚠️ 7 Flaky
✅ 2480 Passed

@uladzimirdev uladzimirdev requested a review from alxnddr May 13, 2024 07:32
@uladzimirdev
Copy link
Contributor Author

maybe this general approach is better, but we need additional testing and maybe RFC for it #42549

@uladzimirdev uladzimirdev added the no-backport Do not backport this PR to any branch label May 13, 2024
alxnddr
alxnddr approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@alxnddr alxnddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it as is for now and backport

@uladzimirdev uladzimirdev added backport Automatically create PR on current release branch on merge and removed no-backport Do not backport this PR to any branch labels May 18, 2024
@uladzimirdev uladzimirdev merged commit 5d795be into master May 18, 2024
154 of 156 checks passed
@uladzimirdev uladzimirdev deleted the exclude-heavy-deps-from-bundle branch May 18, 2024 10:03
github-actions bot pushed a commit that referenced this pull request May 18, 2024
@uladzimirdev
Exclude jspdf and html2canvas from the bundle (#42536)
d6d3a6d 
* Exclude jspdf and html2canvas from the bundle

* cleanup
@metabase-bot metabase-bot bot mentioned this pull request May 18, 2024
Merged
metabase-bot bot added a commit that referenced this pull request May 18, 2024
@metabase-bot @uladzimirdev
Exclude jspdf and html2canvas from the bundle (#42536) (#42872)
344b549 
* Exclude jspdf and html2canvas from the bundle

* cleanup

Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
oisincoveney pushed a commit that referenced this pull request May 20, 2024
@uladzimirdev @oisincoveney
Exclude jspdf and html2canvas from the bundle (#42536)
821c26b 
* Exclude jspdf and html2canvas from the bundle

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxnddr alxnddr alxnddr approved these changes

Assignees

@uladzimirdev uladzimirdev

Labels
backport Automatically create PR on current release branch on merge .Team/QueryingComponents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

separate jspdf and html2canvas from the vendors chunk
2 participants
@uladzimirdev @alxnddr