Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow description columns to be dimensions of charts #42539

Merged
merged 1 commit into from May 14, 2024
Merged

allow description columns to be dimensions of charts #42539

merged 1 commit into from May 14, 2024

Conversation

alxnddr
Copy link
Member

@alxnddr alxnddr commented May 10, 2024

Description

This PR allows columns with "Description" semantic types to be used as chart dimensions for x-axis.

How to verify

  • In the Table Metadata editor change the Product -> Category semantic type to "Description"
  • Create a new question from the Product table -> Summarize Count by Created At and Category
  • Ensure you can use Category as a breakout dimension

Demo

Screenshot 2024-05-10 at 6 56 38 PM

Checklist

  • Tests have been added/updated to cover changes in this PR

@alxnddr alxnddr requested a review from a team May 10, 2024 21:57
@metabase-bot metabase-bot bot added the .Team/DashViz Dashboard and Viz team label May 10, 2024
@replay-io replay.io
Copy link

replay-io bot commented May 10, 2024 •
edited

Status Complete ↗︎
Commit f2e306f
Results
⚠️ 5 Flaky
✅ 2482 Passed

@alxnddr alxnddr added the no-backport Do not backport this PR to any branch label May 14, 2024
@alxnddr alxnddr added this to the 0.50 milestone May 14, 2024
@alxnddr alxnddr enabled auto-merge (squash) May 14, 2024 02:46
@alxnddr alxnddr merged commit 0ecb5b0 into master May 14, 2024
138 of 149 checks passed
@alxnddr alxnddr deleted the allow-description-columns-as-dimension branch May 14, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmmadUsmani EmmadUsmani EmmadUsmani approved these changes

Assignees

@alxnddr alxnddr

Labels
no-backport Do not backport this PR to any branch .Team/DashViz Dashboard and Viz team
Projects
None yet
Milestone
0.50
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alxnddr @EmmadUsmani