Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added speaker monitor service labels #2390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huseyinbabal
Copy link

@huseyinbabal huseyinbabal commented May 2, 2024

Is this a BUG FIX or a FEATURE ?:
/kind bug

What this PR does / why we need it:
Fixes #2389

Special notes for your reviewer:
You can verify the rendered template for metallb-spekaer-monitor-service as follows;

  1. Render helm chart
helm template metallb  --set prometheus.serviceMonitor.enabled=true --set prometheus.serviceAccount=prometheus-monitoring-kube-prometheus --set prometheus.namespace=monitoring > /tmp/metallb-new.yaml
  1. Check /tmp/metallb-new.yaml file for metallb-speaker-monitor-service if it contains label app.kubernetes.io/name with value metallb

Release note:

TODO

Signed-off-by: huseyinbabal <huseyinbabal88@gmail.com>
@huseyinbabal huseyinbabal force-pushed the add-labels-to-speaker-service branch from c960967 to f32eb66 Compare May 2, 2024 11:12
@github-actions github-actions bot added kind/bug and removed kind/bug labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing speaker monitor service label for proper metric labeling
1 participant