Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data room #69

Open
mfts opened this issue Sep 16, 2023 · 11 comments
Open

Data room #69

mfts opened this issue Sep 16, 2023 · 11 comments
Assignees
Milestone

Comments

@mfts
Copy link
Owner

mfts commented Sep 16, 2023

Natural extension of one document, one link.

For those who don't know what a data room is, think of it like a Linktree for documents: one link gives you access to many curated documents.

This is the advanced version of #63

@mfts mfts added this to the Roadmap milestone Sep 16, 2023
@Aashish-Upadhyay-101
Copy link
Contributor

hey @mfts I would like to take this.

@mfts
Copy link
Owner Author

mfts commented Oct 9, 2023

Yes absolutely!

The goal is that we have one link and this links enables access to multiple documents.
Each document should still track the engagement for each visitor.

Let me know if you have any questions @Aashish-Upadhyay-101

@digant2482
Copy link
Contributor

Hey @Aashish-Upadhyay-101 are you working on this issue ?

@Aashish-Upadhyay-101
Copy link
Contributor

@digant2482 I am currently working on notification feature, you can take this if you want 🥇

@digant2482
Copy link
Contributor

Thank you @Aashish-Upadhyay-101. On it !!!

@mfts
Copy link
Owner Author

mfts commented Oct 30, 2023

Awesome @digant2482

@digant2482
Copy link
Contributor

digant2482 commented Nov 2, 2023

Hi @mfts. Just wanted to take your opinion on my design/functionality. Please check the video:

Features:
Data room section on sidebar.
Data room page.
Data room modal to add documents to modal
Add documents to data room modal.

Features to be done:
Prisma schema (add data room table)
Backend API's to fetch data rooms

Suggestions:
I had to fetch links related to documents from backend for which I used fetch, I noticed there's useSWR hook to fetch links but the issue was, it was fetching document id from URL (which only happens if user is on documents page), we can give argument for that hook to use it throughout application.

Will complete everything by tomorrow. Please provide feedback (if any) on changes needed to be done
https://github.com/mfts/papermark/assets/73285842/00ef2040-2b89-49a1-be5d-8356fa24f5f4

@mfts
Copy link
Owner Author

mfts commented Nov 3, 2023

@digant2482 it's similar to #63

The goal is to have one link that gives access to many documents. As a recipient, I receive a link to a data room. I enter my email and then I see a folder structure to navigate the data room. When I visit each document within the dataroom, it will be tracked like a usual..

Video looks good but I don't think you built it with one link yet. Let me know if you have any question

@digant2482
Copy link
Contributor

digant2482 commented Nov 3, 2023

Thank you for the update, @mfts.

Update:
The dataroom dashboard is now complete, including the frontend, backend, and database components.

Question regarding developed part:

  1. Do we want to track the "dataroom created" event in plausible?
    P.S: I have added "dataroom created" type for tracking for JITSU.

I've submitted a draft pull request (#142) for code review. Here's a video related to the PR:

bandicam.2023-11-04.22-17-44-680.mp4

Tomorrow, I'll begin working on the recipient's page. I do have one question, though: Do we want a folder structure similar to Google Drive, where users can navigate through folders to access documents, or do we prefer a single page layout similar to Linktree, which lists all documents at once?

Please let me know if there are any additional changes or updates you'd like to make.

@digant2482
Copy link
Contributor

Hi, @mfts. I have create both versions (Linktree like datarooms and folder structure dataroom). Please check the videos for the same:
Folder structure dataroom
https://github.com/mfts/papermark/assets/73285842/1043d06b-a0c5-40fc-814b-e66f3f27cc5a

Linktree dataroom
https://github.com/mfts/papermark/assets/73285842/d6201efa-6028-408e-bcf9-8ff9463b7abf

Key points:
Hierarchical Datarooms

  • Google Drive like folder structure
  • Tracks links
  • Edit/Delete file/folder names
  • Navigation bar for easy navigation
  • Only single backend call for whole
    dataroom by maintaining state in frontend
    using useReducer hook
  • Optimized re-renders using React memo
  • Can edit dataroom name, description by
    clicking on it
  • Tracks dataroom views in database
  • Send emails to owner if dataroom is viewed
  • Email protection, password protection
    for datarooms (Default email verification
    required)
  • Plus more...

Linktree (Single-paged datarooms)

  • Quick link-tree like datarooms
  • Tracks links
  • Tracks dataroom views in database
  • Send emails to owner if dataroom is viewed
  • Email protection, password protection
    for datarooms (Default email verification
    required)
  • Input validation on inputs

@mamscience
Copy link

mamscience commented Feb 6, 2024

Really looking forward to this feature.

#243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants