Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dataroom #166

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Feat/dataroom #166

wants to merge 39 commits into from

Conversation

digant2482
Copy link
Contributor

#69 . Review required

Copy link

vercel bot commented Nov 25, 2023

@digant2482 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

@mfts
Copy link
Owner

mfts commented Dec 1, 2023

Thanks @digant2482. Could you consolidate the schema migrations into one and resolve the merge conflicts.

It looks really good so far. I'm keen to add this to launch week 🚀

Copy link
Contributor

@Aashish-Upadhyay-101 Aashish-Upadhyay-101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digant2482 could you just create single migration for the data-room feature?
I mean you created around 15 migrations. I would recommend you to just do a single migration.

@Aashish-Upadhyay-101
Copy link
Contributor

@digant2482 also please Pull in latest changes and resolve the conflicts : )

@Aashish-Upadhyay-101
Copy link
Contributor

@digant2482 also you should scope Data Room by Team

@digant2482
Copy link
Contributor Author

@digant2482 could you just create single migration for the data-room feature? I mean you created around 15 migrations. I would recommend you to just do a single migration.

Done

@digant2482
Copy link
Contributor Author

Ready for review !!! 🚀

@digant2482 digant2482 marked this pull request as ready for review December 3, 2023 13:05
@digant2482 digant2482 requested a review from mfts as a code owner December 3, 2023 13:05
.env.example Outdated Show resolved Hide resolved

/* Handle on hover */
::-webkit-scrollbar-thumb:hover {
background: #555;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want this scrollbar effect on the entire website? or only on some specific components?
If you are trying to just use this effect for some components/pages then, creating a custom utility class would be better I think.
reference: here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentional. It looks nicer than default one. It is for whole website not a specific component. Though I can change that if needed. @mfts input required.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide a visual as I haven't run this PR locally yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next.config.js Outdated Show resolved Hide resolved
@mfts
Copy link
Owner

mfts commented Dec 21, 2023

Hey @digant2482 i think having two versions of a dataroom will be confusing for many users, especially since we have none right now.

I would suggest going with the linktree style for now and tabling the hierarchical dataroom for a future time

@digant2482
Copy link
Contributor Author

@mfts. On it

@Aashish-Upadhyay-101
Copy link
Contributor

@digant2482 any updates?
please respond, otherwise I will have to stab in and complete this feature ; )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants