-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/dataroom #166
base: main
Are you sure you want to change the base?
Feat/dataroom #166
Conversation
@digant2482 is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
Thanks @digant2482. Could you consolidate the schema migrations into one and resolve the merge conflicts. It looks really good so far. I'm keen to add this to launch week 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@digant2482 could you just create single migration for the data-room feature?
I mean you created around 15 migrations. I would recommend you to just do a single migration.
@digant2482 also please Pull in latest changes and resolve the conflicts : ) |
@digant2482 also you should scope Data Room by |
Done |
Ready for review !!! 🚀 |
|
||
/* Handle on hover */ | ||
::-webkit-scrollbar-thumb:hover { | ||
background: #555; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want this scrollbar effect on the entire website? or only on some specific components?
If you are trying to just use this effect for some components/pages then, creating a custom utility class would be better I think.
reference: here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentional. It looks nicer than default one. It is for whole website not a specific component. Though I can change that if needed. @mfts input required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide a visual as I haven't run this PR locally yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @digant2482 i think having two versions of a dataroom will be confusing for many users, especially since we have none right now. I would suggest going with the linktree style for now and tabling the hierarchical dataroom for a future time |
@mfts. On it |
@digant2482 any updates? |
#69 . Review required