Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced analytics filtering #158

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vndpal
Copy link
Contributor

@vndpal vndpal commented Nov 18, 2023

Feature request: Disable individual visits from total document / link statistics #96

  • Added dropdowns to allow users to either deselect individual visits/links so that they can see the chart without counting the de-selected views/links
  • Filtering the from the Tinybird SQL using NOT IN clause as we are expecting that our users will usually de-select views that are distorting the chart with incorrect data.
  • Since I have modified the existing pipe with version number 2, we will have to run tb push lib\tinybird\endpoints\get_total_average_page_duration.pipe to push the data to tinybird server. I noticed it takes a few minutes to reflect the changes after pushing.

Closed the old PR #123 and raised this PR as the old branch became stale with many conflicts.

@vndpal vndpal requested a review from mfts as a code owner November 18, 2023 15:32
Copy link

vercel bot commented Nov 18, 2023

@vndpal is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

@vndpal
Copy link
Contributor Author

vndpal commented Dec 13, 2023

@mfts, this PR is ready for review.

@mfts
Copy link
Owner

mfts commented Feb 28, 2024

We just implemented a way to filter "internal visitors" with #318. You solution is more complete however, I'd like to use react-table for filtering the analytics straight for the visitors and links tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants