Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of the image plugin with CGO build options for FreeBSD #643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MatthiasPetermann
Copy link

With the attached change, filestash can also be created on FreeBSD if the required static libraries are installed. I have successfully tested it on FreeBSD/amd64. To make it work, I had to duplicate the go files and create one variant for FreeBSD and one for Linux. I'm not sure if there is a more elegant way to do this, but if this is acceptable, it would be nice if you could accept this pull request.

@mickael-kerjean
Copy link
Owner

That's very nice thank you. The plg_image_c is very bleeding edge and adding support for freebsd sounds very good although since your PR I've added support for gif thumbnail using libgif and that will probably cause some issues as well. Do you mind adding support for libgif with the new gif thumbnailer using the same approach you've done here? To my knowledge your PR is perfect, we're simply missing support for the gif thumbnailer

In the same way as jpeg, heic, png and other raw format, it's based on another C program using libgif: https://github.com/mickael-kerjean/filestash/blob/master/server/plugin/plg_image_c/image_gif.c

If you have any question don't hesitate to reach out

@MatthiasPetermann
Copy link
Author

Thanks for your response - seems I missed it in the first place. Sure, I will check out the latest revision and try to add libgif support as well. Kind regards, Matthias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants