Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go-git and Google API dependency vulnerabilities #684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisyuska
Copy link

This PR fixes several CVEs that have been reported, but primarily targets these two:

  1. gopkg.in/src-d/go-git.v4 CVE-2023-49569 (9.8)
  2. google.golang.org/grpc CVE-2023-44487 (7.5)

Steps taken

go.mod and go.sum changes were auto-generated by running:

  1. go get github.com/go-git/go-git/v5
  2. go get google.golang.org/api
  3. go mod tidy

@chrisyuska
Copy link
Author

chrisyuska commented Apr 14, 2024

Hey @mickael-kerjean , I just wanted to call attention to this. I rely on this application (thank you btw!), but AWS is reporting these CVEs on the container scans. The dependency updates appear to be fully backwards-compatible, but I'm not able to verify 100%.

@mickael-kerjean
Copy link
Owner

It will take a bit of time to review as I don't want to introduce some weird issue by upgrading some deps

@chrisyuska
Copy link
Author

Totally reasonable. I reviewed the two dependencies' changelogs and didn't see any breaking changes outside of go-git's renamed package, but there is a fair bit of indirect dependency updates too. Let me know if I can help in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants