New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New integration - CometMonitor #5466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CometMonitor
alexkuzmik
requested review from
awan-10,
mrwyattii,
tjruwase and
loadams
as code owners
April 25, 2024 19:44
alexkuzmik
changed the title
[DRAFT] New integration - CometMonitor
New integration - CometMonitor
Apr 25, 2024
@microsoft-github-policy-service agree company="Comet" |
…d train_batch_size from 1 to 2 in TestCometMonitor
Hi, @loadams! I hope I fixed the issues in my unit tests (they revealed themselves only in multi-gpu env). Could you please re-run the tests? |
loadams
reviewed
May 9, 2024
loadams
reviewed
May 15, 2024
|
||
|
||
Deepspeed's Monitor module can log training details into a [Tensorboard](https://www.tensorflow.org/tensorboard)-compatible file, to [WandB](https://wandb.ai/site), or to simple CSV files. Below is an overview of what DeepSpeed will log automatically. | ||
Deepspeed's Monitor module can log training details into a [Tensorboard](https://www.tensorflow.org/tensorboard)-compatible file, to [WandB](https://wandb.ai/site), to [Comet](https://www.comet.com/site/?utm_source=deepseed&utm_medium=docs&utm_content=docs) or to simple CSV files. Below is an overview of what DeepSpeed will log automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth just linking to the main comet.com site?
loadams
approved these changes
May 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new monitoring option -
CometMonitor
which comes up as an official integration with CometML.The new monitor is covered with unit tests.
Notes:
docs/code-docs/source/monitor.rst
but it doesn't look used anymoreconfig-json.md
to be generic so the next integration won't require updating it.