Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New integration - CometMonitor #5466

Merged
merged 20 commits into from May 15, 2024
Merged

New integration - CometMonitor #5466

merged 20 commits into from May 15, 2024

Conversation

alexkuzmik
Copy link
Contributor

@alexkuzmik alexkuzmik commented Apr 25, 2024

This PR introduces a new monitoring option - CometMonitor which comes up as an official integration with CometML.

The new monitor is covered with unit tests.

Notes:

  • We've updated docs/code-docs/source/monitor.rst but it doesn't look used anymore
  • We've updated the "Monitoring Module" section name in config-json.md to be generic so the next integration won't require updating it.

@alexkuzmik alexkuzmik changed the title [DRAFT] New integration - CometMonitor New integration - CometMonitor Apr 25, 2024
@alexkuzmik
Copy link
Contributor Author

alexkuzmik commented Apr 25, 2024

@microsoft-github-policy-service agree company="Comet"

@alexkuzmik
Copy link
Contributor Author

alexkuzmik commented May 8, 2024

Hi, @loadams! I hope I fixed the issues in my unit tests (they revealed themselves only in multi-gpu env). Could you please re-run the tests?



Deepspeed's Monitor module can log training details into a [Tensorboard](https://www.tensorflow.org/tensorboard)-compatible file, to [WandB](https://wandb.ai/site), or to simple CSV files. Below is an overview of what DeepSpeed will log automatically.
Deepspeed's Monitor module can log training details into a [Tensorboard](https://www.tensorflow.org/tensorboard)-compatible file, to [WandB](https://wandb.ai/site), to [Comet](https://www.comet.com/site/?utm_source=deepseed&utm_medium=docs&utm_content=docs) or to simple CSV files. Below is an overview of what DeepSpeed will log automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth just linking to the main comet.com site?

@loadams loadams added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@loadams loadams added this pull request to the merge queue May 15, 2024
Merged via the queue into microsoft:master with commit 488a823 May 15, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants