DeepSpeedCheckpoint: support custom final ln idx #5506
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjruwase
reviewed
May 8, 2024
nelyahu
force-pushed
the
DeepSpeedCheckpoint
branch
from
97dec42
to
68984ee
Compare
till today only last layer (idx=-1) was considered using FINAL_LAYER_NORM_INDEX which is set to -1. this commit allow the user to pass custom value for model where this default value does not apply.
nelyahu
force-pushed
the
DeepSpeedCheckpoint
branch
from
68984ee
to
c5e5ade
Compare
tjruwase
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
till today only last layer (idx=-1) was considered using FINAL_LAYER_NORM_INDEX which is set to -1.
this PR allows the user to pass custom value for model where this default value does not apply.
see example for usage in HabanaAI/Megatron-DeepSpeed fork repository:
https://github.com/HabanaAI/Megatron-DeepSpeed/blob/c9feb8cacabc6dd4da4266cff08db555a21122e2/tools/verify_checkpoint_non_tp_consistency.py#L296