-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [ci] [python-package] add arm64 macOS wheels #6391
Draft
jameslamb
wants to merge
15
commits into
master
Choose a base branch
from
python/arm64-wheels
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5328.
Adds
arm64
macOS wheels for the Python package.Notes for Reviewers
This is not ready for review.
It seems that Azure DevOps does not support
arm64
macOS runners... only GitHub Actions: actions/runner-images#8971.We'll have to build and publish that particular wheel on GitHub Actions.
How I tested this
Get a run ID from CI, looking at the URL.
e.g. for this build: https://github.com/microsoft/LightGBM/actions/runs/8963252466/job/24613276364?pr=6391
the run id is
8963252466
.Then, following https://docs.github.com/en/actions/managing-workflow-runs/downloading-workflow-artifacts?tool=cli, use the GitHub CLI to download the wheels. A fine-grained access token with just read-only permission on
Actions
should be enough.From the root of the repo:
rm -rf ./whl-tmp mkdir -p ./whl-tmp RUN_ID=8963252466 gh run download \ --repo microsoft/LightGBM \ "${RUN_ID}" \ -n macosx-arm64-wheel \ --dir ./whl-tmp
Inspected it with
pydistcheck
.Installed from the wheel (on my M2 mac, using macOS 14.4.1).
Ran some tests.
That failed for that particular run (tests segfault), but just documenting how I'm testing.