Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AADAdministrativeUnit enabling advanced query #4683

Merged
merged 8 commits into from
May 27, 2024
Merged

Conversation

ifinch
Copy link
Contributor

@ifinch ifinch commented May 16, 2024

Pull Request (PR) description

Implemented advanced query based on this
https://learn.microsoft.com/en-us/graph/aad-advanced-queries?tabs=http#administrative-unit-properties

This Pull Request (PR) fixes the following issues

None

@ifinch
Copy link
Contributor Author

ifinch commented May 16, 2024

@NikCharlebois any idea why the unit test fails?

revised the code and changed the approach to avoid the issue on the testing
@NikCharlebois
Copy link
Collaborator

We will need to add an entry in the changelog.md file to describe the change.

@ifinch
Copy link
Contributor Author

ifinch commented May 22, 2024

Done

@FabienTschanz
Copy link
Contributor

@ifinch The entry in the changelog should be in this branch and not in a separate pull request for better visibility. Or mention that those two pull requests are linked #4683 and #4700

@ifinch
Copy link
Contributor Author

ifinch commented May 27, 2024

The #4683 (the change) and #4700 (changelog update) are linked .

Removed Property    = $propertiesToRetrieve as it shouldn't be there
@ifinch ifinch requested a review from NikCharlebois May 27, 2024 11:56
@NikCharlebois NikCharlebois merged commit f47ad31 into microsoft:Dev May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants