Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXOAntiPhishPolicy: Change var PhishThresholdLevel type #4687

Open
wants to merge 2 commits into
base: Dev
Choose a base branch
from

Conversation

ricmestre
Copy link
Contributor

@ricmestre ricmestre commented May 20, 2024

Pull Request (PR) description

Variable PhishThresholdLevel is of type string, but in reality it's actually an integer (valid from 1 to 4), in fact the exports already are generated that way and include integers and not strings.

This is affecting my unit tests since I'm generating my own blueprints which take the type of the variable from the schema which is string but the resulting blueprint comes up with an integer and therefore they fail.

Usually this would be considered a breaking change but in this case it doesn't affect the current exports because they already follow the reality and PhishThresholdLevel is exported as an integer, see below.

        EXOAntiPhishPolicy "EXOAntiPhishPolicy-EXOAntiPhishPolicy_1"
        {
            AdminDisplayName                              = "";
            ApplicationId                                 = $EXOApplicationId;
            AuthenticationFailAction                      = "MoveToJmf";
            CertificateThumbprint                         = $EXOCertThumbprint;
            Enabled                                       = $True;
            EnableFirstContactSafetyTips                  = $False;
            EnableMailboxIntelligence                     = $True;
            EnableMailboxIntelligenceProtection           = $True;
            EnableOrganizationDomainsProtection           = $True;
            EnableSimilarDomainsSafetyTips                = $True;
            EnableSimilarUsersSafetyTips                  = $False;
            EnableSpoofIntelligence                       = $True;
            EnableTargetedDomainsProtection               = $False;
            EnableTargetedUserProtection                  = $False;
            EnableUnauthenticatedSender                   = $True;
            EnableUnusualCharactersSafetyTips             = $False;
            EnableViaTag                                  = $True;
            Ensure                                        = "Present";
            ExcludedDomains                               = @();
            ExcludedSenders                               = @();
            HonorDmarcPolicy                              = $True;
            Identity                                      = "EXOAntiPhishPolicy_1";
            ImpersonationProtectionState                  = "Automatic";
            MailboxIntelligenceProtectionAction           = "NoAction";
            MailboxIntelligenceProtectionActionRecipients = @();
            MailboxIntelligenceQuarantineTag              = "DefaultFullAccessPolicy";
            MakeDefault                                   = $False;
            PhishThresholdLevel                           = 1;
            SpoofQuarantineTag                            = "DefaultFullAccessPolicy";
            TargetedDomainActionRecipients                = @();
            TargetedDomainProtectionAction                = "NoAction";
            TargetedDomainQuarantineTag                   = "DefaultFullAccessPolicy";
            TargetedDomainsToProtect                      = @();
            TargetedUserActionRecipients                  = @();
            TargetedUserProtectionAction                  = "NoAction";
            TargetedUserQuarantineTag                     = "DefaultFullAccessPolicy";
            TargetedUsersToProtect                        = @();
            TenantId                                      = $OrganizationName;
        }

This Pull Request (PR) fixes the following issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants