Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PTRun] Remove full stops in plugin descriptions #32613

Merged
merged 1 commit into from
May 31, 2024
Merged

[PTRun] Remove full stops in plugin descriptions #32613

merged 1 commit into from
May 31, 2024

Conversation

HydroH
Copy link
Contributor

@HydroH HydroH commented Apr 25, 2024

Summary of the Pull Request

Removed full stops in PowerToys Run plugin descriptions, and unified appearances of 'Examples' to 'e.g.' to make descriptions more consistent.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

image

Jay-o-Way
Jay-o-Way reviewed Apr 25, 2024
View reviewed changes
src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate/Properties/Resources.resx
@@ -202,7 +202,7 @@
<comment>'UTC' means here 'Universal Time Convention'</comment>
</data>
<data name="Microsoft_plugin_timedate_plugin_description" xml:space="preserve">
<value>Provides time and date values for the system time or a custom time stamp (Examples: '{0}', '{1}', '{2}', '{3}')</value>
<value>Provides time and date values for the system time or a custom time stamp (e.g.'{0}', '{1}', '{2}', '{3}')</value>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your image, there is no space in e.g.'Day' Do you happen to know why?

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Apr 25, 2024 •
edited

Off-topic: I see you use ( for the time/date plugin. Some characters and phrases may conflict with global queries of other plugins if you use them as activation commands. For example, using ( breaks global calculation queries starting with an opening parenthesis. The default is changed to ).

@HydroH
Copy link
Contributor Author

HydroH commented Apr 25, 2024

Off-topic: I see you use ( for the time/date plugin. Some characters and phrases may conflict with global queries of other plugins if you use them as activation commands. For example, using ( breaks global calculation queries starting with an opening parenthesis. The default is changed to ).

Thanks for reminding! I never manually set this, I guess the default was changed sometime during updates?

@Jay-o-Way
Copy link
Collaborator

I guess the default was changed sometime during updates

It's been a while ago. But yes. It would be too much of a "breaking change" to actively change user's settings. So many people still have it.

jaimecbernardo
jaimecbernardo approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 4c9e181 into microsoft:main May 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-o-Way Jay-o-Way Jay-o-Way left review comments

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

Assignees
No one assigned
Labels
Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HydroH @Jay-o-Way @jaimecbernardo