Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MeasureTool] Update default activation shortcut to resolve conflict with Windows Explorer built-in shortcut #32732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nx-frost
Copy link

@nx-frost nx-frost commented May 5, 2024

Summary of the Pull Request

Update default activation shortcut and resolve #32623

PR Checklist

Detailed Description of the Pull Request / Additional comments

The default activation shortcut for the Screen Ruler (MeasureTool) has been updated so as to no longer conflict with the built-in Windows Explorer shortcut used to restore windows minimized with ⊞ Win-M:

  • Old shortcut: ⊞ Win-Shift-M
  • New shortcut: ⊞ Win-Ctrl-Shift-M

Validation Steps Performed

  • Installed the package on a fresh virtual machine
  • Launched PowerToys
  • Pressed ⊞ Win-Ctrl-Shift-M
  • Observed that this caused the MeasureTool UI to appear and function normally

@jaimecbernardo
Copy link
Collaborator

@ethanfangg , thoughts about the default shortcut here ? I think this is OK since it (Win+Ctrl+Shift+M) isn't used by us elsewhere. Is it used by Windows for something?

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Thanks you for the contribution! Now just need some PM confirmation regarding use of this shortcut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer Win-Ctrl-Shift-M instead of Windows native shortcut Win-Shift-M for Screen Ruler
2 participants