This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
update "any" types to more specific #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update references from bowdenk7 repo to Microsoft repo
added package-lock for npm5 and fixed bug with flash messages
Added `build` `preLaunchTask` for debug configuration
Removed duplication in npm scripts `serve` and `watch`
…MaxOptions'. fix err TypeScript-Node-Starter/src/controllers/api.ts[6, 9]: missing whitespace, 8 files fix bugs of issue 15
fit bugs of issue 15 and some other bugs caused by tslint
port changes from PR microsoft#11 and update package.lock from latest npm version
fix: copying issues
Added link to vscode TSLint extention in readme Thanks to @x4m3
This fixes the YAML related extensions errors in VSCode, as the schema for .travis.yml requires a quoted strings here: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions Thanks!
The configuration for Jest tests with support fo the TypeScript files are now handled by Jest configuration file. Thanks!
There is existing @types definition for express-flash. Let's use it and just augment a method required by the existing code to please compiler. Thanks!
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.13) Signed-off-by: dependabot[bot] <support@github.com>
…rn/lodash-4.17.13 Bump lodash from 4.17.11 to 4.17.13 #dependabot
This removes NPM audit warnings which seems to be raised by the older version of the lock file. This one was regenerated with NPM v6.9.0 (Node v10.*) Thanks!
Update NPM lock down file.
…lash-types Simplify augmented module for express-flash
…-nodejs-versions Specify NodeJS version as strings in Travis configuration
📝 remove reference to legacy file. Closes microsoft#190
This commit rewrites linting support in the project to be based solely on the ESLint as advised by the TSLint tool authors: https://medium.com/palantir/tslint-in-2019-1a144c2317a9 The migration is based on default, recommended settings for TypeScript in ESLint and is expected to be updated in future to better fit project goals. All references has been updated and replaced with relevant ESLint context: - dependencies migration from TSLint to ESLint - VSCode configuration changes to support ESLint exension - VSCode extensions recommendation changes - `.eslintrc` and `.eslintignore` configuration files added - all error level problems in the source files are covered by this migration Thanks!
✨ Migrate TSLint to ESLint. Closes microsoft#209
fix lint error
```
PS> npm run lint
> express-typescript-starter@0.1.0 lint C:\Users\JipingWang\source\repos\api
> tsc --noEmit && eslint '*/**/*.{js,ts}' --quiet --fix
Oops! Something went wrong! :(
ESLint: 5.16.0.
No files matching the pattern "'*/**/*.{js,ts}'" were found.
Please check for typing mistakes in the pattern.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! express-typescript-starter@0.1.0 lint: `tsc --noEmit && eslint '*/**/*.{js,ts}' --quiet --fix`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the express-typescript-starter@0.1.0 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\JipingWang\AppData\Roaming\npm-cache\_logs\2019-07-18T15_26_05_580Z-debug.log
```
fix lint error
Fix lint warnings
Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.2. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.4.0...v1.4.2) Signed-off-by: dependabot[bot] <support@github.com>
…rn/eslint-utils-1.4.2 Bump eslint-utils from 1.4.0 to 1.4.2
Use update indexes access in Mongoose configuration. Fixes microsoft#225
- upgrade to latest packages - cast `req.user` as `UserDocument` - update logger to use latest Winston syntax - disable `no-inferrable-types`, Mongoose use unified topology Thx to @CarlosSolrac
Update User model update "any" types to more specific
|
Now that #235 is merged, would be nice to actually update those |
brittanydrandolph
force-pushed
the
master
branch
from
fbc1328
to
1e15e8b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update User model
augment express.Request with User model
copy of #230 ; didn't know it's advised to push from separate branch.