Handle exported functions in ExportDeclarations for CJS/AMD/UMD emit #58489

jakebailey · 2024-05-09T18:27:05Z

Not 100% certain on this but the baselines look right. Feel free to make your own better fix for this, though; this was just my naive attempt.

jakebailey · 2024-05-09T18:27:43Z

tests/baselines/reference/jsDeclarationsDefault.js

+exports.default = foo;
+exports.bar = foo;
 exports.default = foo;
 exports.bar = foo;


This duplication doesn't feel too great. I probably missed something.

Fixed this via a Set.

jakebailey · 2024-05-09T18:28:54Z

tests/baselines/reference/jsDeclarationsFunctions.js

 exports.a = a;
 exports.b = b;
 exports.c = c;
 exports.d = d;
 exports.e = e;
 exports.f = f;
+exports.g = g;
+exports.h = hh;


Example of this working, in the test case:

/** * @param {{x: string}} a * @param {{y: typeof b}} b */ function hh(a, b) { return a.x && b.y(); } export { hh as h };

jakebailey · 2024-05-09T20:39:45Z

@typescript-bot perf test this faster

typescript-bot · 2024-05-09T20:39:47Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-05-09T21:22:11Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,449k (± 0.93%)}	_{192,794k (± 0.76%)}	_~	_192,144k	_195,787k	_{p=0.298 n=6}
_{Parse Time}	_{1.29s (± 0.98%)}	_{1.29s (± 1.44%)}	_~	_1.26s	_1.31s	_{p=0.622 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.52s (± 0.33%)}	_{9.52s (± 0.45%)}	_~	_9.48s	_9.58s	_{p=0.936 n=6}
_{Emit Time}	_{2.65s (± 0.53%)}	_{2.65s (± 0.21%)}	_~	_2.64s	_2.65s	_{p=0.498 n=6}
_{Total Time}	_{14.18s (± 0.19%)}	_{14.18s (± 0.33%)}	_~	_14.13s	_14.25s	_{p=0.936 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,141	_407,141	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,221,993k (± 0.00%)}	_{1,222,062k (± 0.00%)}	_{+69k (+ 0.01%)}	_1,222,039k	_1,222,098k	_{p=0.020 n=6}
_{Parse Time}	_{6.77s (± 0.52%)}	_{6.80s (± 0.49%)}	_~	_6.75s	_6.84s	_{p=0.296 n=6}
_{Bind Time}	_{1.87s (± 0.48%)}	_{1.88s (± 0.65%)}	_~	_1.86s	_1.89s	_{p=0.445 n=6}
_{Check Time}	_{31.08s (± 0.23%)}	_{31.12s (± 0.31%)}	_~	_30.98s	_31.22s	_{p=0.378 n=6}
_{Emit Time}	_{14.80s (± 0.49%)}	_{14.78s (± 0.52%)}	_~	_14.68s	_14.87s	_{p=1.000 n=6}
_{Total Time}	_{54.52s (± 0.25%)}	_{54.58s (± 0.25%)}	_~	_54.37s	_54.78s	_{p=0.470 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,961,290	_1,961,290	_~	_~	_~	_{p=1.000 n=6}
_Types	_696,905	_696,905	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,778,084k (± 0.00%)}	_{1,778,075k (± 0.00%)}	_~	_1,778,036k	_1,778,101k	_{p=0.575 n=6}
_{Parse Time}	_{6.78s (± 0.17%)}	_{6.77s (± 0.30%)}	_~	_6.75s	_6.80s	_{p=0.744 n=6}
_{Bind Time}	_{2.31s (± 0.51%)}	_{2.31s (± 1.08%)}	_~	_2.27s	_2.33s	_{p=0.864 n=6}
_{Check Time}	_{57.01s (± 0.35%)}	_{57.13s (± 0.56%)}	_~	_56.71s	_57.52s	_{p=0.810 n=6}
_{Emit Time}	_0.14s	_0.14s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{66.24s (± 0.30%)}	_{66.35s (± 0.51%)}	_~	_65.89s	_66.73s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,220,317	_1,220,267	_{-50 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_258,942	_258,936	_{-6 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,334,081k (± 0.03%)}	_{2,334,121k (± 0.03%)}	_~	_2,333,442k	_2,335,497k	_{p=0.810 n=6}
_{Parse Time}	_{5.01s (± 0.48%)}	_{5.01s (± 1.10%)}	_~	_4.95s	_5.11s	_{p=0.687 n=6}
_{Bind Time}	_{1.87s (± 0.73%)}	_{1.87s (± 0.48%)}	_~	_1.86s	_1.88s	_{p=0.803 n=6}
_{Check Time}	_{33.51s (± 0.39%)}	_{33.57s (± 0.26%)}	_~	_33.44s	_33.71s	_{p=0.575 n=6}
_{Emit Time}	_{2.64s (± 2.26%)}	_{2.66s (± 1.42%)}	_~	_2.60s	_2.71s	_{p=0.873 n=6}
_{Total Time}	_{43.05s (± 0.32%)}	_{43.11s (± 0.32%)}	_~	_42.86s	_43.27s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,220,317	_1,220,267	_{-50 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_258,942	_258,936	_{-6 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,410,712k (± 0.02%)}	_{2,435,652k (± 2.49%)}	_~	_2,409,730k	_2,559,612k	_{p=0.575 n=6}
_{Parse Time}	_{7.79s (± 1.18%)}	_{7.79s (± 1.34%)}	_~	_7.62s	_7.93s	_{p=0.936 n=6}
_{Bind Time}	_{2.51s (± 0.60%)}	_{2.50s (± 1.10%)}	_~	_2.47s	_2.55s	_{p=0.686 n=6}
_{Check Time}	_{49.46s (± 0.27%)}	_{49.50s (± 0.22%)}	_~	_49.38s	_49.68s	_{p=0.575 n=6}
_{Emit Time}	_{3.89s (± 3.70%)}	_{3.89s (± 1.85%)}	_~	_3.82s	_3.98s	_{p=0.810 n=6}
_{Total Time}	_{63.63s (± 0.34%)}	_{63.69s (± 0.43%)}	_~	_63.37s	_64.11s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,476	_256,426	_{-50 (- 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,239	_104,233	_{-6 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{425,383k (± 0.02%)}	_{425,362k (± 0.03%)}	_~	_425,281k	_425,568k	_{p=0.423 n=6}
_{Parse Time}	_{3.35s (± 0.78%)}	_{3.37s (± 0.67%)}	_~	_3.35s	_3.40s	_{p=0.279 n=6}
_{Bind Time}	_{1.30s (± 0.93%)}	_{1.31s (± 0.64%)}	_~	_1.29s	_1.31s	_{p=1.000 n=6}
_{Check Time}	_{17.74s (± 0.34%)}	_{17.69s (± 0.47%)}	_~	_17.58s	_17.82s	_{p=0.295 n=6}
_{Emit Time}	_{1.37s (± 2.15%)}	_{1.37s (± 1.26%)}	_~	_1.35s	_1.39s	_{p=0.628 n=6}
_{Total Time}	_{23.76s (± 0.31%)}	_{23.73s (± 0.46%)}	_~	_23.59s	_23.90s	_{p=0.689 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,818k (± 0.04%)}	_{369,734k (± 0.02%)}	_~	_369,635k	_369,855k	_{p=0.378 n=6}
_{Parse Time}	_{2.85s (± 0.75%)}	_{2.85s (± 0.87%)}	_~	_2.81s	_2.88s	_{p=1.000 n=6}
_{Bind Time}	_{1.59s (± 1.17%)}	_{1.58s (± 0.77%)}	_~	_1.57s	_1.60s	_{p=0.933 n=6}
_{Check Time}	_{15.56s (± 0.21%)}	_{15.57s (± 0.42%)}	_~	_15.51s	_15.66s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.99s (± 0.22%)}	_{20.01s (± 0.42%)}	_~	_19.91s	_20.12s	_{p=0.810 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,810,147	_2,810,147	_~	_~	_~	_{p=1.000 n=6}
_Types	_953,583	_953,583	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,981,816k (± 0.01%)}	_{2,981,795k (± 0.00%)}	_~	_2,981,644k	_2,982,017k	_{p=0.689 n=6}
_{Parse Time}	_{16.93s (± 0.28%)}	_{16.95s (± 0.20%)}	_~	_16.91s	_16.99s	_{p=0.466 n=6}
_{Bind Time}	_{5.04s (± 2.20%)}	_{5.02s (± 0.51%)}	_~	_4.98s	_5.05s	_{p=0.373 n=6}
_{Check Time}	_{91.37s (± 3.45%)}	_{90.68s (± 3.59%)}	_~	_88.11s	_94.89s	_{p=0.810 n=6}
_{Emit Time}	_{26.63s (± 9.58%)}	_{27.41s (± 8.72%)}	_~	_24.30s	_29.26s	_{p=0.423 n=6}
_{Total Time}	_{139.97s (± 0.43%)}	_{140.06s (± 0.64%)}	_~	_138.99s	_141.16s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,424	_108,424	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,482k (± 0.01%)}	_{410,465k (± 0.01%)}	_~	_410,419k	_410,498k	_{p=0.471 n=6}
_{Parse Time}	_{3.84s (± 1.25%)}	_{3.84s (± 0.65%)}	_~	_3.80s	_3.87s	_{p=0.872 n=6}
_{Bind Time}	_{1.66s (± 0.89%)}	_{1.66s (± 0.45%)}	_~	_1.65s	_1.67s	_{p=0.934 n=6}
_{Check Time}	_{16.90s (± 0.29%)}	_{16.92s (± 0.43%)}	_~	_16.85s	_17.01s	_{p=0.747 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.40s (± 0.15%)}	_{22.42s (± 0.32%)}	_~	_22.34s	_22.53s	_{p=0.936 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,576	_524,576	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,847	_178,847	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,578k (± 0.01%)}	_{462,562k (± 0.02%)}	_~	_462,458k	_462,736k	_{p=0.378 n=6}
_{Parse Time}	_{3.89s (± 0.22%)}	_{3.88s (± 0.35%)}	_~	_3.87s	_3.90s	_{p=0.804 n=6}
_{Bind Time}	_{1.44s (± 0.84%)}	_{1.44s (± 0.76%)}	_~	_1.42s	_1.45s	_{p=0.677 n=6}
_{Check Time}	_{22.48s (± 0.90%)}	_{22.42s (± 0.82%)}	_~	_22.22s	_22.66s	_{p=0.689 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.80s (± 0.71%)}	_{27.75s (± 0.64%)}	_~	_27.55s	_27.97s	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey added 2 commits May 9, 2024 11:25

Handle exported functions in ExportDeclarations for CJS/AMD/UMD emit

c670db7

Update baselines

6570b92

jakebailey requested a review from rbuckton May 9, 2024 18:27

typescript-bot assigned jakebailey May 9, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 9, 2024

jakebailey commented May 9, 2024

View reviewed changes

jakebailey added 4 commits May 9, 2024 12:50

Typo

2d7d907

Fix duplication

d65145f

Update baselines

d522648

Use a plain set like the other variables returned here

2faeb15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle exported functions in ExportDeclarations for CJS/AMD/UMD emit #58489

Handle exported functions in ExportDeclarations for CJS/AMD/UMD emit #58489

jakebailey commented May 9, 2024

jakebailey May 9, 2024

jakebailey May 9, 2024

jakebailey May 9, 2024

jakebailey commented May 9, 2024

typescript-bot commented May 9, 2024 •

edited

typescript-bot commented May 9, 2024

tsc

Handle exported functions in ExportDeclarations for CJS/AMD/UMD emit #58489

Are you sure you want to change the base?

Handle exported functions in ExportDeclarations for CJS/AMD/UMD emit #58489

Conversation

jakebailey commented May 9, 2024

jakebailey May 9, 2024

Choose a reason for hiding this comment

jakebailey May 9, 2024

Choose a reason for hiding this comment

jakebailey May 9, 2024

Choose a reason for hiding this comment

jakebailey commented May 9, 2024

typescript-bot commented May 9, 2024 • edited

typescript-bot commented May 9, 2024

tsc

typescript-bot commented May 9, 2024 •

edited