Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support Offline Mode for VSIX ProjectTemplate #4327

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ghost1372
Copy link
Contributor

Fix microsoft/microsoft-ui-xaml#9535

If there is no internet connection, the project will not be created Because of adding nuget package (wasdk) dynamically

This PR checks the internet connection:

  • If the internet is available And the latest version is available as a cache/Locally, Installs the latest cached version.
  • If the cached/Local version is not available, the latest version will be installed from nuget.org
  • If the internet is not available, then the latest version will be installed from cache/Local

Also i Changed IVsPackageInstaller to IVsPackageInstaller2 because there is a Method Called InstallLatestPackage which can install latest version.

A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

@Scottj1s
Copy link
Member

@ghost1372 thanks so much for this contribution! we'll look at getting it merged very soon.

@ghost1372
Copy link
Contributor Author

ghost1372 commented May 5, 2024

I merged latest changes.
can anyone review this pr?
@bpulliam
@Scottj1s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASDK Nuget Package cannot be installed if there is no internet connection!
3 participants