-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MenuList): Removing ignoreKeydown from MenuList. #31393
base: master
Are you sure you want to change the base?
Conversation
packages/react-components/react-menu/src/components/MenuList/useMenuList.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-menu/src/components/MenuList/useMenuList.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-menu/src/components/MenuList/useMenuList.ts
Outdated
Show resolved
Hide resolved
📊 Bundle size reportUnchanged fixtures
|
Oops. Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…seMenuList.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
packages/react-components/react-menu/src/components/MenuList/useMenuList.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-menu/src/components/MenuList/useMenuList.ts
Show resolved
Hide resolved
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 602 | 596 | 5000 | |
Button | mount | 309 | 309 | 5000 | |
Field | mount | 1146 | 1143 | 5000 | |
FluentProvider | mount | 706 | 707 | 5000 | |
FluentProviderWithTheme | mount | 82 | 80 | 10 | |
FluentProviderWithTheme | virtual-rerender | 35 | 34 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 69 | 67 | 10 | |
MakeStyles | mount | 842 | 879 | 50000 | |
Persona | mount | 1767 | 1734 | 5000 | |
SpinButton | mount | 1385 | 1363 | 5000 | |
SwatchPicker | mount | 1526 | 1551 | 5000 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I will let @ling1726 to check it
@mshoho this looks suspicious |
packages/react-components/react-menu/src/components/MenuList/useMenuList.ts
Show resolved
Hide resolved
@mshoho this looks suspicious yes, I've checked for the cause and this is due to how events are exported from Tabster — event classes are bundled regardless of not being used. I am rearranging Tabster exports and will fix that in a subsequent PR today or tomorrow. |
@mshoho this looks suspicious @mshoho let's fix before merging this PR. |
@mshoho this looks suspicious #31441 (comment) — this should do it (so far it references the new canary, I'll release 8.0.0 once it's approved in the Tabster repo). |
MenuList had ignoreKeydown for Tab to prevent Tabster from handling the Tab press. As a side effect this ignoreKeydown was affecting submenus too. This PR uses TabsterMoveFocusEvent to prevent Tabster from handling the Tab press in a particular case that doesn't affect submenus.