-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Priority Work on Connections #4279
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4279 +/- ##
==========================================
- Coverage 85.44% 85.05% -0.39%
==========================================
Files 56 56
Lines 15384 15426 +42
==========================================
- Hits 13145 13121 -24
- Misses 2239 2305 +66 ☔ View full report in Codecov by Sentry. |
96a51a3
to
930b0a6
Compare
#endif | ||
StartProcessing = CxPlatListIsEmpty(&OperQ->List) && !OperQ->ActivelyProcessing; | ||
CxPlatListInsertTail(*OperQ->PriorityTail, &Oper->Link); | ||
OperQ->PriorityTail = &Oper->Link.Flink; |
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning
parameter
CIFulzz is failling in Any idea of affecting releasing Operation by changing operation order. |
Description
Sometimes an application would like to prefer new work over existing work already queued on the connection. This PR adds the notion of priority to the connection's operation queue, and exposes flags through the API to allow the app to chose to leverage this.
Testing
SpinQuic updated.
Need to add some explicit BVTs.
Documentation
TODO