QuicTestValidateConnectionEvents3 fix to use duoNic with normal socket #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4310 +/- ##
==========================================
- Coverage 86.04% 85.26% -0.79%
==========================================
Files 56 56
Lines 15382 15382
==========================================
- Hits 13236 13115 -121
- Misses 2146 2267 +121 ☔ View full report in Codecov by Sentry. |
nibanks
reviewed
May 17, 2024
| QuicAddrGetFamily(&ServerLocalAddr.SockAddr), | ||
| QuicAddrGetFamily(&ServerLocalAddr.SockAddr) == QUIC_ADDRESS_FAMILY_INET ? QUIC_ADDRESS_FAMILY_INET : QUIC_ADDRESS_FAMILY_INET6, |
There was a problem hiding this comment.
This is always 0, which does not work appropriately with duonic as it assert check the family whether 4 or 6.
Normal socket case just uses ipv6 localhost if it is 0. This change is for duonic to work with 0.
nibanks
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One fix of #4309
Testing
Build without "-EnableLinuxXDP"
./artifacts/bin/linux/x64_Debug_openssl3/msquictest --gtest_filter="ParameterValidation/WithValidateConnectionEventArgs.ValidateConnectionEvents/2" --duoNicLocally passed
Documentation
N/A