Uninitialize LossDetection earlier to cleanup Datagram frame

[ami-GS]

Description

App allocated buffer for Datagram Frame has been leaking due to

• missing callback handler when waiting Ack for the Datagram frame.
• allocation failure for packet metadata

Testing

Ran local test. No leak detected. No leak found from my own memory tracker either.
./artifacts/bin/linux/x64_Debug_openssl3/spinquic both -timeout:600000 -repeat_count:20 -alloc_fail:100
./artifacts/bin/linux/x64_Debug_openssl/spinquic both -timeout:600000 -repeat_count:20 -alloc_fail:100

Let's see automation results

Documentation

N/A

[nibanks]

Since there are still leaks, even with this change, I feel like QuicDatagramSendShutdown isn't getting called before shutdown complete somehow. Can you add some debug asserts for:

1. Before the shutdown complete event, assert that Datagram has been shutdown/disabled.
2. Before the shutdown complete event, assert that zero outstanding datagrams are pending.

[nibanks]

I wonder if we need to add a QuicDatagramSendShutdown after QuicSendUninitialize in this same function. Though it really should be getting called in QuicConnTryClose.

[ami-GS]

DatagramSend is still called after QuicDatagramSendShutdown which touches released Datagram->ApiQueueLock then crash

[ami-GS]

Another leak

    QUIC_SENT_PACKET_METADATA* SentPacket =
        QuicSentPacketPoolGetPacketMetadata(
            &Connection->Worker->SentPacketPool, TempSentPacket->FrameCount);

[ami-GS]

The QUIC_SENT_PACKET_METADATA should be released by QuicLossDetectionUninitialize....

[ami-GS]

There is still case of QUIC_DATAGRAM_SEND_SENT -> QUIC_DATAGRAM_SEND_LOST_SUSPECT -> leak

[ami-GS]

• LossDetection->SentPackets
• LossDetection->LostPackets

are cleaned by QuicLossDetectionUninitialize in QuicConnOnShutdownComplete though

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (9cab5bf) to head (997bff5).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4316      +/-   ##
==========================================
- Coverage   86.04%   85.06%   -0.99%     
==========================================
  Files          56       56              
  Lines       15382    15384       +2     
==========================================
- Hits        13236    13086     -150     
- Misses       2146     2298     +152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ami-GS]

Fixed!

[nibanks]

LGTM. Thanks for making these changes!

[nibanks]

I see there are a number of BVT failures. I"m rerunning them to see if they are real regressions or not.

[ami-GS]

Linux XDP related is fixed by different PR

[nibanks]

We talked in person about a slightly different way to do this. Please update. Thanks!