feat(ct): class and object components #30269
Open
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sand4rt
force-pushed
the
component-detection
branch
from
2c3149b
to
b1119c1
Compare
7 tasks
Test results for "tests 1"2 flaky26930 passed, 619 skipped Merge workflow run. |
This was referenced Apr 12, 2024
|
@pavelfeldman any chance this one could passthrough? |
10 tasks
|
👋 @sand4rt 👋 taking care of our review debt. is this something you'd like me to look at? |
|
👋 @pavelfeldman, yes please. Let me know if more info is needed. I think @dgozman also has an opinion about this BTW. He mentioned something about this during the Angular PR review (a similar change is proposed there): #27783 (comment) |
| @@ -2,6 +2,7 @@ import { test, expect } from '@playwright/experimental-ct-vue'; | |||
| import Button from '@/components/Button.vue'; | |||
| import EmptyTemplate from '@/components/EmptyTemplate.vue'; | |||
| import Component from '@/components/Component.vue'; | |||
| import { Story } from '@/components/Story'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29544 and introduces an improved approach for creating multiple wrapper/story components within a single file (considering it's only possible to define one component in a
.vuefile). @yjaaidi made the change intsxTransform.ts