Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(trace): add context create event for test runner #30697

Merged
merged 3 commits into from May 14, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented May 7, 2024

Adding metadata event to the test.trace to simplify time computation logic.

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would store and use monotonicTime (not offset) for simplicity.

This comment has been minimized.

Adding metadata event to the test.trace to simplify time computation logic.
@yury-s yury-s force-pushed the metadata-event-in-runner-trace branch from a63acb4 to 79796dd Compare May 14, 2024 00:19
@yury-s yury-s changed the title chore(trace): store monotonic time offset in metadata event chore(trace): add context create event for test runner May 14, 2024

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

1 flaky ⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline

27333 passed, 662 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit 873f3a0 into microsoft:main May 14, 2024
30 checks passed
@yury-s yury-s deleted the metadata-event-in-runner-trace branch May 14, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants