Filter test cases by annotation text in HTML report #30751
Merged
+46
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
packages/html-reporter/src/filter.ts
Outdated
| @@ -45,6 +46,10 @@ export class Filter { | |||
| labels.add(token); | |||
| continue; | |||
| } | |||
| if (token.startsWith('a:')) { | |||
There was a problem hiding this comment.
a: would be ambiguous here (thing attachments, etc). How about "annot:"
amankagithub
force-pushed
the
aman/filter-by-annotation
branch
2 times, most recently
from
0ffa4ba
to
4f0e48d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
May 22, 2024
packages/html-reporter/src/filter.ts
Outdated
| @@ -45,6 +46,10 @@ export class Filter { | |||
| labels.add(token); | |||
| continue; | |||
| } | |||
| if (token.startsWith('annot:')) { | |||
| annotations.add(token.slice(6)); | |||
There was a problem hiding this comment.
Suggested change
| annotations.add(token.slice(6)); | |
| annotations.add(token.substring('annot:'.length)); |
packages/html-reporter/src/filter.ts
Outdated
|
|
||
| if (this.annotations.length) { | ||
| const matches = this.annotations.every(annotation => | ||
| searchValues.annotations.some(_annotation => _annotation.includes(annotation))); |
There was a problem hiding this comment.
Suggested change
| searchValues.annotations.some(_annotation => _annotation.includes(annotation))); | |
| searchValues.annotations.some(a => a.includes(annotation))); |
|
@microsoft-github-policy-service agree |
|
Thanks! I'll merge it once the nits from the previous review are addressed. |
amankagithub
force-pushed
the
aman/filter-by-annotation
branch
from
4f0e48d
to
2b2e958
Compare
Test results for "tests 1"1 flaky27056 passed, 609 skipped Merge workflow run. |
pavelfeldman
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request : #30141
At Atlassian , we add team name , component name to annotations . If we want to search test case by teams on the HTML report we don't have any way .
In this PR , I had added the functionality to search by annotation .
Out of all tests there are two test cases with annotations .
If we just add to
authorin annotation search , both the test case appears .If we add
author=amanonly one test case appears . Same withauthor=alex