Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: [WIP] OTel model diagnostics: streaming APIs #6242

Merged
merged 12 commits into from
May 15, 2024
Merged

.Net: [WIP] OTel model diagnostics: streaming APIs #6242

merged 12 commits into from
May 15, 2024

Conversation

TaoChenOSU
Copy link
Contributor

@TaoChenOSU TaoChenOSU commented May 14, 2024 •
edited

Motivation and Context

Previously (#6150) we added support for OTel (LLM semantic conventions) to non-streaming APIs in the AI connectors. This PR adds that to streaming APIs.

Description

  1. Add OTel (LLM semantic conventions) to streaming APIs.
  2. Update the telemetry sample to use streaming APIs along with non-streaming ones..

Contribution Checklist

@TaoChenOSU TaoChenOSU self-assigned this May 14, 2024
@TaoChenOSU TaoChenOSU requested a review from a team as a code owner May 14, 2024 06:05
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels May 14, 2024
@github-actions github-actions bot changed the title [WIP] OTel model diagnostics: streaming APIs .Net: [WIP] OTel model diagnostics: streaming APIs May 14, 2024
@TaoChenOSU TaoChenOSU added this pull request to the merge queue May 15, 2024
Merged via the queue into microsoft:main with commit b99b77f May 15, 2024
15 checks passed
@TaoChenOSU TaoChenOSU deleted the taochen/otel-model-diagnostics-streaming branch May 15, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@alliscode alliscode alliscode approved these changes

@RogerBarreto RogerBarreto Awaiting requested review from RogerBarreto

@markwallace-microsoft markwallace-microsoft Awaiting requested review from markwallace-microsoft

Assignees

@TaoChenOSU TaoChenOSU

Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TaoChenOSU @stephentoub @alliscode @markwallace-microsoft