Added pathlib support and resolved conflicts.

[pioneerHitesh]

added pathlib support , removed checked_instance_type function

[adamjstewart]

Let's wait for a response on pytorch/vision#8120 before we do too much. We might be able to get them to support pathlib in the next release.

[pioneerHitesh]

Let's wait for a response on pytorch/vision#8120 before we do too much. We might be able to get them to support pathlib in the next release.

@adamjstewart may you please check your LinkedIn.

[adamjstewart]

Based on the current state of pytorch/vision#8120, I think the easiest thing to do for now would be to define functions in torchgeo.datasets.utils that are simply wrappers around the torchvision functions. These functions would accept both str and pathlib, then we would cast to str for torchvision. Then we wouldn't need to cast in every single dataset file. Thoughts?

[pioneerHitesh]

Based on the current state of pytorch/vision#8120, I think the easiest thing to do for now would be to define functions in torchgeo.datasets.utils that are simply wrappers around the torchvision functions. These functions would accept both str and pathlib, then we would cast to str for torchvision. Then we wouldn't need to cast in every single dataset file. Thoughts?

@adamjstewart It seems like they have added support for pathlib in datasets/utils.py. The following PR is for the same. So we may not need to define extra functions for casting pathlib to str. Let me know if we should start work or wait some more time?

[adamjstewart]

Fantastic, let's wait until that makes it into a stable release and then rebase this PR.

[adamjstewart]

I believe torchvision 0.18 includes full pathlib support. If you're still interested, now would be a good time to try to revive this. It's probably easiest to create a new PR since most files have changed since last year.

As a first pass, can you change the type hints (without changing the code or type casting) just to see how much of pathlib we already support? Torchvision only supports str | Path[str], so let's do the same in TorchGeo.