Rename Json::Object iterator fields to "key" and "value" #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
Oct 21, 2023
| @@ -200,12 +200,24 @@ namespace vcpkg::Json | |||
|
|
|||
| struct Object | |||
| { | |||
| struct value_type | |||
There was a problem hiding this comment.
I prefer to call this ObjectProperty or similar rather than a nested struct.
BillyONeal
reviewed
Oct 21, 2023
Comment on lines
+205
to
+206
| value_type(std::string sv, Value&& v) : key(std::move(sv)), value(std::move(v)) { } | ||
| value_type(std::string sv, const Value& v) : key(std::move(sv)), value(v) { } |
There was a problem hiding this comment.
I think it would be better to avoid double string moves here. How about something like:
Suggested change
| value_type(std::string sv, Value&& v) : key(std::move(sv)), value(std::move(v)) { } | |
| value_type(std::string sv, const Value& v) : key(std::move(sv)), value(v) { } | |
| template<class StringLike, class ValueLike> | |
| value_type(StringLike&& s, ValueLike&& v) : key(std::forward<StringLike>(sv)), value(std::forward<ValueLike>(v)) { } |
Alternately, can this thing be an aggregate?
Convert CeMetadata manipulation to adhere to existing JsonDeserializer requirements. (This is in preparation for tracking original source locations through Json deserialization)
ras0219-msft
force-pushed
the
dev/roschuma/json-obj-iter
branch
from
c99f95d
to
a4ad9dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert CeMetadata manipulation to adhere to existing JsonDeserializer requirements.
(This is in preparation for tracking original source locations through Json deserialization)