Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong Header-only usage message #1403

Merged
merged 2 commits into from
May 14, 2024

Conversation

LilyWangLL
Copy link
Contributor

@LilyWangLL LilyWangLL commented May 7, 2024

This regression is from PR #1368.
The wrong message as below:

bext-sml is header-only and can be used from CMake via:

  find_path(BEXT_SML_INCLUDE_DIRS ")boost/sml.hpp")
  target_include_directories(main PRIVATE ${BEXT_SML_INCLUDE_DIRS})

@LilyWangLL LilyWangLL marked this pull request as ready for review May 7, 2024 08:55
@BillyONeal
Copy link
Member

In general, I think when we are fixing regressions like this I think we should be adding tests for the regression unless we can show that it isn't reasonable to do so. Clearly, we've demonstrated that's a bug we might write :)

In this case I had discovered the same bug and fix over in #1405 so I already had a test handy so I just moved it over here.

@BillyONeal BillyONeal merged commit cae13bd into microsoft:main May 14, 2024
5 checks passed
@BillyONeal
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants