compatible with CMAKE_${lang}_OSX_DEPLOYMENT_TARGET_FLAG #38735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonicaLiu0311
added
the
category:tool-update
LilyWangLL
approved these changes
May 16, 2024
data-queue
reviewed
May 17, 2024
| list(GET VCPKG_LANGUAGES 0 lang) | ||
| string(APPEND ${flag_var} " ${CMAKE_${lang}_OSX_DEPLOYMENT_TARGET_FLAG}${CMAKE_OSX_DEPLOYMENT_TARGET}") | ||
| list(GET CMAKE_OSX_ARCHITECTURES 0 arch) |
There was a problem hiding this comment.
Given CMAKE_OSX_ARCHITECTURES could specify multiple architectures, should this be a for loop?
There was a problem hiding this comment.
Pinging @Arlen-LT for response.
LilyWangLL
removed
the
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CMake 3.28.4 which support xcode 15.2 and xros deployment version, the content of Modules/Platform/Apple-Clang.cmake has changed as per commit 40be88a9:
This approach is unlike the traditional
-m{platform}-version-min=and causes issues whenset(VCPKG_OSX_SYSROOT xros)andset(VCPKG_OSX_DEPLOYMENT_TARGET *.*). By debugging thebuildtrees/$port/config.logof any port, there is a flag pass to compiler like--target=<ARCH>-apple-xros<VERSION_MIN>*.*, as there is no compatible way similar to other Apple platforms (e.g., a flag like-mxros-version-min=) until now(05/15/2024).So on my opinion, although there is currently no official or community triplet for building xros, maintaining compatibility with CMake is preferable. This patch will not affect those who are not using xros, it is only for future compatibility.