Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scnlib] Fix include CMAKE_INSTALL_INCLUDEDIR #38746

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented May 16, 2024

Fixes include CMAKE_INSTALL_INCLUDEDIR since target scn::scn lost INTERFACE_INCLUDE_DIRECTORIES,

Fixed by backporting upstream patches in eliaskosunen/scnlib#111.

Format and unify EOL to LF of portfile.cmake.

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

The port usage tests pass with the following triplets:

  • x64-linux
  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 16, 2024
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review May 16, 2024 03:18
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 17, 2024
@data-queue data-queue merged commit de9557b into microsoft:master May 17, 2024
17 checks passed
@WangWeiLin-MV WangWeiLin-MV deleted the port/scnlib/backport-20240515-6-e149892 branch May 17, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants