Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline] Adding lunarg-vulkantools and qt5-serialbus as fail in ci.baseline.txt #38752

Merged
merged 1 commit into from
May 17, 2024

Conversation

JonLiu1993
Copy link
Member

Fixes regression: https://dev.azure.com/vcpkg/public/_build/results?buildId=102737&view=results

REGRESSION: lunarg-vulkantools:x64-linux failed with BUILD_FAILED
REGRESSION: qt5-serialbus:x64-linux failed with BUILD_FAILED

Error:

/usr/bin/ld: /mnt/vcpkg-ci/b/krb5/x64-linux-dbg/lib/gssapi/krb5/../../.././../src/krb5-1-8a38cd677f.clean/src/lib/gssapi/krb5/export_name.c:61: undefined reference to `krb5_free_context'
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels May 16, 2024
@JonLiu1993
Copy link
Member Author

The correct repair method should be to disable gssapi feature in qt5-base.

@Neumann-A
Copy link
Contributor

Please fix the regressions instead of masking them .....

@JonLiu1993
Copy link
Member Author

Please fix the regressions instead of masking them .....

Because the local machine cannot reproduce this error, we are currently testing PR and trying to fix it.

@Neumann-A
Copy link
Contributor

Because the local machine cannot reproduce this error

As most of the times if there are uncontrolled dependencies..... look at what ports where added the last month. #38402 added krb5 as such install that which the features CI would install first before everything else.

@Neumann-A
Copy link
Contributor

(and make sure you don't use your current binary cache when rebuilding. Otherwise you just pull the working version from there)

@JonLiu1993
Copy link
Member Author

Yes, we have reproduced all errors in the test PR #38670 and are currently analyzing and solving them.

@data-queue data-queue marked this pull request as ready for review May 17, 2024 01:35
@data-queue
Copy link
Contributor

ci.baseline.txt should reflect current state, and these failures are being fixed in #38670

@data-queue data-queue merged commit c66fd55 into microsoft:master May 17, 2024
17 checks passed
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 17, 2024
@JonLiu1993 JonLiu1993 deleted the dev/Jon/baseline branch May 17, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants